Fix stdlib_stream bootstrap AOT stream JIT parity (#1152)#1159
Merged
Conversation
PurHur
force-pushed
the
fix/issue-1152-stdlib-stream-aot
branch
2 times, most recently
from
c96b61f to
0b99848
Compare
Store stream handles with explicit writeLong/writeBool instead of copyFromPointer and separate fread strings before boxing to avoid intermittent AOT crashes. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/issue-1152-stdlib-stream-aot
branch
from
0b99848 to
830dda6
Compare
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/bootstrap-aot/stdlib_stream.phpby assigning fopen stream handles with explicitwriteLong/writeBoolinstead ofcopyFromPointer.__string__separatebefore boxing to avoid invalid frees.stdlib_filesystem.php) instead of unimplementedsys_get_temp_dir/getmypidhelpers.Test plan
php bin/compile.php -o build/bootstrap-aot/stdlib_stream test/bootstrap-aot/stdlib_stream.php1)stdlib_stream.phpMade with Cursor