Fix bootstrap stdlib_stream AOT fixture path (#1152)#1161
Merged
Conversation
Use a repo-local temp directory instead of sys_get_temp_dir()/getmypid() so VM and AOT binaries agree on fopen/fread/fclose I/O during bootstrap link. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/bootstrap-aot/stdlib_stream.phpoutput mismatch between VM and AOT by using a repo-local fixture directory (same pattern asstdlib_filesystem.phpafter Fix bootstrap stdlib filesystem AOT and add stream JIT (#1116, #1117) #1134).sys_get_temp_dir()/getmypid()from the bootstrap link target so fopen/fread/fclose agree across interpreters.Closes #1152.
Test plan
./script/docker-ci-local.sh(full local CI gate)php test/bootstrap-aot/stdlib_stream.phpand AOT binary both emit1Made with Cursor