Runtime __DIR__/__FILE__ on include stack (#707)#710
Closed
PurHur wants to merge 2 commits into
Closed
Conversation
…). Defer __DIR__ and __FILE__ to VM/JIT opcodes backed by a script path stack, normalize compile paths for relative CLI scripts, and fold literal includes when the including file is known. Closes the gap for MiniWebApp template paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Use write slots for __DIR__/__FILE__ sentinel operands so Router and other user methods do not treat them as unresolved call arguments. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Superseded by #709 (already merged to master with TYPE_SCRIPT_MAGIC + ScriptStack). Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__DIR__and__FILE__to runtimeTYPE_MAGIC_DIR/TYPE_MAGIC_FILEopcodes backed by a VM script path stack (push oninclude, pop on return).Runtime::parse()so relative CLI paths (phpc run,bin/jit.php) still fold__DIR__ . '/file.php'literal includes.magic_dir_nested) and capability-syntax rows for Docs: capabilities-syntax rows for __DIR__, __FILE__, __LINE__ (#85) #706/Language: VM/JIT runtime __DIR__/__FILE__ on include stack (#85) #707.Test plan
./script/docker-ci-local.sh fast --filter 'IncludeLiteralTest|CapabilitySyntaxTest'__DIR__/__FILE__testCompileFoldsLiteralIncludeForRelativeScriptPath)Closes #707. Related: #85, #706.
Made with Cursor