Fix VM include paths after #707 script magic#713
Merged
Conversation
Use compile-time literalIncludePaths/deploy paths in TYPE_INCLUDE instead of evaluating a broken runtime path, and harden ScriptStack::normalize() against null bytes. Tighten apply-patches detection for magic-script-const. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged #709 (#707): MiniWebApp VM failed because
TYPE_INCLUDEevaluated include paths at runtime (sometimes producing null-byte garbage) instead of using compile-timeliteralIncludePaths/ deploy specs.literalIncludePaths/deployIncludePathswhen present.ScriptStack::normalize().php-cfg-magic-script-const.patchby Parser content, not only file existence.Test plan
MiniWebAppVmCliTest(4 tests)IncludeLiteralTestVM testsMade with Cursor