From f8b86dd98f4ce5230994ae334ae22154dada2d2a Mon Sep 17 00:00:00 2001 From: Daniele Esposti Date: Wed, 20 Feb 2013 11:48:11 +0000 Subject: [PATCH 1/2] Fixed parameter name in notification's constructor --- src/puremvc/interfaces.py | 4 ++-- src/puremvc/patterns/facade.py | 6 +++--- src/puremvc/patterns/observer.py | 12 ++++++------ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/puremvc/interfaces.py b/src/puremvc/interfaces.py index e59f728..633ef07 100644 --- a/src/puremvc/interfaces.py +++ b/src/puremvc/interfaces.py @@ -28,7 +28,7 @@ class INotifier(object): @see: L{INotification} """ - def sendNotification(self, notificationName, body=None, noteType=None): + def sendNotification(self, notificationName, body=None, type=None): """ Send a C{INotification}. @@ -39,7 +39,7 @@ def sendNotification(self, notificationName, body=None, noteType=None): @param notificationName: the name of the notification to send @param body: the body of the notification (optional) - @param noteType: the type of the notification (optional) + @param type: the type of the notification (optional) """ raise NotImplementedError(self) diff --git a/src/puremvc/patterns/facade.py b/src/puremvc/patterns/facade.py index f9e723c..422b301 100644 --- a/src/puremvc/patterns/facade.py +++ b/src/puremvc/patterns/facade.py @@ -273,7 +273,7 @@ def hasMediator(self, mediatorName): """ return self.view.hasMediator(mediatorName) - def sendNotification(self, notificationName, body=None, noteType=None): + def sendNotification(self, notificationName, body=None, type=None): """ Create and send an C{INotification}. @@ -282,9 +282,9 @@ def sendNotification(self, notificationName, body=None, noteType=None): @param notificationName: the name of the notiification to send @param body: the body of the notification (optional) - @param noteType: the type of the notification (optional) + @param type: the type of the notification (optional) """ - self.notifyObservers(puremvc.patterns.observer.Notification(notificationName, body, noteType)) + self.notifyObservers(puremvc.patterns.observer.Notification(notificationName, body, type)) def notifyObservers(self, notification): """ diff --git a/src/puremvc/patterns/observer.py b/src/puremvc/patterns/observer.py index a3fc8d5..ee12ea1 100644 --- a/src/puremvc/patterns/observer.py +++ b/src/puremvc/patterns/observer.py @@ -149,7 +149,7 @@ def __init__(self, *args, **kwds): """ self.multitonKey = None - def sendNotification(self, notificationName, body=None, noteType=None): + def sendNotification(self, notificationName, body=None, type=None): """ Create and send an C{INotification}. @@ -159,10 +159,10 @@ def sendNotification(self, notificationName, body=None, noteType=None): @param notificationName: the name of the notification to send @param body: the body of the notification (optional) - @param noteType: the type of the notification (optional) + @param type: the type of the notification (optional) """ if self.facade: - self.facade.sendNotification(notificationName, body, noteType) + self.facade.sendNotification(notificationName, body, type) def initializeNotifier(self, key): """ @@ -226,13 +226,13 @@ class Notification(puremvc.interfaces.INotification): @see: L{Observer} """ - def __init__(self, name, body=None, noteType=None): + def __init__(self, name, body=None, type=None): """ Constructor. @param name: name of the C{Notification} instance. (required) @param body: the C{Notification} body. (optional) - @param noteType: the type of the C{Notification} (optional) + @param type: the type of the C{Notification} (optional) """ """The name of the notification instance""" @@ -242,7 +242,7 @@ def __init__(self, name, body=None, noteType=None): self.body = body """The type of the notification instance""" - self.type = noteType + self.type = type def __repr__(self): """ From 8820cf1b23f18a3050cbf0e182bf469a2c306537 Mon Sep 17 00:00:00 2001 From: Daniele Esposti Date: Wed, 20 Feb 2013 11:50:51 +0000 Subject: [PATCH 2/2] Updated revision number and changelog --- VERSION | 10 +++++++--- setup.py | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/VERSION b/VERSION index 7b8f136..232f1c4 100644 --- a/VERSION +++ b/VERSION @@ -1,14 +1,18 @@ PureMVC MultiCore Framework for Python (Ported) -------------------------------------------------------------------------- -Release Date: 10/25/2012 +Release Date: 20/02/2013 Platform: Python 2.5+ Version: 1 Revision: 0 - Minor: 0 + Minor: 1 Authors: Toby de Havilland Daniele Esposti -------------------------------------------------------------------------- -1.0 - * Official PureMVC.org release +1.0.1 - * Renamed 'noteType' keyword in Notification's constructor to 'type' + for consistency + +1.0.0 - * Official PureMVC.org release + 0.3.2 - * Added unit test for non-null values in Proxy's constructor * Fixes in unit tests code to support Python 2.5 diff --git a/setup.py b/setup.py index 4ec54c6..cc803a5 100644 --- a/setup.py +++ b/setup.py @@ -1,7 +1,7 @@ from distutils.core import setup setup(name='PureMVC Multicore Python', - version='1.0.0', + version='1.0.1', description='PureMVC Multicore Python Framework', author='Toby de Havilland, Daniele Esposti', author_email='toby.de.havilland@puremvc.org, expo@expobrain.net',