Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil item names and formatting is buggy #1252

Closed
3 tasks done
xGinko opened this issue Jan 18, 2023 · 3 comments
Closed
3 tasks done

Anvil item names and formatting is buggy #1252

xGinko opened this issue Jan 18, 2023 · 3 comments

Comments

@xGinko
Copy link

xGinko commented Jan 18, 2023

Spark link

https://spark.lucko.me/FRacraa6TO

Expected behavior

Using the permissions:

purpur.anvil.color
purpur.anvil.format
purpur.anvil.remove_italics

and setting anvil.allow-colors: true should allow a player to use all color and format codes (&k,&m,&l,&6,etc.) available
inside the anvil.

Observed/Actual behavior

All color and format codes work, except for the &k-format code. Itemnames will just say &kExample

Steps/models to reproduce

  • get luckperms + purpur
  • enable config section anvil.allow-colors: true in purpur.yml
  • restart server
  • give yourself the permissions:
purpur.anvil.color
purpur.anvil.format
purpur.anvil.remove_italics
  • Try renaming an item to &kEpic Sword

Purpur version

Current: git-Purpur-1895 (MC: 1.19.3)
Previous: git-Purpur-1883 (MC: 1.19.3)

Agreements

  • I am running the latest version of Purpur available from https://purpurmc.org/downloads.
  • I have searched for and ensured there isn't already an open issue regarding this.
  • My version of Minecraft is supported by Purpur.

Other

Minimessage-format in anvils will work when enabled, BUT:
When having both permissions - purpur.anvil.minimessage and purpur.anvil.color+purpur.anvil.format, only minimessage will work in the anvil. Color and Format codes using the '&' prefix will not work, but instead the color code will be removed from the name.

@granny granny closed this as completed in 7a5b6a5 Jan 22, 2023
@granny
Copy link
Member

granny commented Jan 22, 2023

Minimessage-format in anvils will work when enabled, BUT:
When having both permissions - purpur.anvil.minimessage and purpur.anvil.color+purpur.anvil.format, only minimessage will work in the anvil. Color and Format codes using the '&' prefix will not work, but instead the color code will be removed from the name.

Intentional behavior. If the blocks.anvil.use-mini-message option is enabled and the player has the purpur.anvil.minimessage permission, then color codes will be stripped in favor of using the MiniMessage tags. Color/format codes cannot be used interchangeably with MiniMessage tags.

@xGinko
Copy link
Author

xGinko commented Jan 22, 2023

@granny can you please read the rest of the issue before closing? You only addressed one thing out of 2.

@xGinko
Copy link
Author

xGinko commented Jan 22, 2023

Ah I see its been addressed in 7a5b6a5

Thank you for your time! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants