Tidy Compatibility, Refactors, Bugfixes #46
Conversation
…ator to allow prettier to format without error.
…g. Made content event handling a static/shareable function to allow for alternate sheet integration. Removed all unnecessary event handling for the MI tab. Added manual item updating to spell/feat/table delete icon click events. Ensured the MI tab stays selected between renders when interacting with delete icons. Added manual item updating when dropping a relevant entity onto the MI tab. Began to extract `onDrop` for more public shareability.
…lears all data on construction if it is disabled.
…without the MagicItemTab class. Made disableMagicItemTabInputs static so that it can be shared with other sheet modules without the MagicItemTab class. Revamped tidy registration to leverage tab contents event listeners, on-drop handling, and tab contents input disabling during onRender callback. Added getData prop for the Handlebars template. Formalized the isAcceptedItemType and isAllowedToShow static functions in MagicItemTab to be shared between Tidy and regular tab handling. Replaced Tidy5eKgarItemSheet constructor detection with API call that checks whether MI2 is dealing with a Tidy sheet.
Made sorting universally applied upon MagicItem construciton, so it is no longer necessary to call on render in MagicItemTab.
…c that maintains focus on the Magic Item tab. The fix was to use a fresh copy of `app` each time something is being done. Otherwise, a previous version of app will be cached in the tab, and all tab activations will be called on a sheet that is no longer being used.
|
I got to a good stopping point for the day. If you are interested in pulling these changes in or testing out what I've done here, please feel free. Tomorrow, I can continue to work on Tidy integration with the Actor sheet. |
|
This will possibly fix #37 also |
Converted the item lists for Magic Item tab to use the standard/default sheet HTML structure/classes. This eliminated the need for a number of CSS styles. Added some minimal layout styles for the item lists. Removed unneeded template content for magic item tab, based on refactors.
Added scaffolding for placing the Wand icon and wiring events for the MI2 content.
Added magic wand for visible magic items logic for New Tidy.
Removed some commented code. Some light refactor/renaming for clarity.
kgar
changed the title
While this is not needed for default-like sheets, because they are slotting into an existing ordered list, for a non-default-like sheet, there may not be a parent ordered list to drop into. Removed d20 from feat and spell sheet templates, as it is not needed. Also removed the CSS style for showing/hiding the d20 icon, because dnd5e sheets are already doing this.
Added some explanatory comments.
Wired up Tidy sheet events with the new statically available version of the sheet event handlers.
Added number util for parsing ints and falling back to a specified numeric value on failure.
… for New Tidy, per community users' requests.
…look and feel in Old Tidy was compromised. Added some emergency patch styles to make Old Tidy presentable until it retires.
…k handler is doing a half-second `setTimeout()` to build items. New Tidy needs thos built items synchronously during render.
- Magic Item requires Equipped and Attuned - Item Attunement is set to "Attunement Not Required" - Item is equipped by Actor
kgar
changed the title
|
Seems to be working and not breaking any compatibility, there are still few quirks (mostly visual) that I'll fix later. Thanks for the gargantuan amount of work you did 😅 . |
|
Thanks for letting me participate. If you ever want to chat about Foundry dev, I'm eager to discuss with other module devs, as I am still learning Foundry dev and techniques for building modules. MI2 is very special to a lot of users. Some of my community members have been asking me about compatibility for a while now. I'm just glad that I could finally get New Tidy to a place where it could offer the appropriate tools for MI2 integration. p4535992 has a commission for more work in MI2, and I'm interested in doing the work for that, however long it takes, as long as you're ok with that. |
|
Sure, as I've written previously, my history with this project is just having it working on Foundry v11, for me and my friends, so I did some minor fixes that took me way too long to figure it out. I also only have time to try and do some things on it during the weekends, since after work I don't really want to look at any code. And I haven't really worked in any JavaScript-like languages, so that's another barrier of problems And that's how we ended up here 😅 - any help is appreciated. |
|
If you ever want to chat on discord, I'm there on the league server and on a few others, like the dedicated Tidy discord server (link on the repo readme). I'm glad to assist in gargantuan ways haha and will defer to your direction on things. I understand the module inner workings a lot better now that I've been in there a bit. |
Related to #30
Item Sheet: Magic Item tab
magicitemtab.js; this tab class will likely pertain only to the default and default(like) sheets.nameattribute saves itself on change)renderwherever able. Changes to MI tab data will trigger a re-render naturally.General/Misc.
Tidy Compatibility
Wrapping Up