Allow user to select audio codec when opening an audio device #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable use of non-default audio codec to open an audio device with a certain host API. e.g. use av.open(file="device_id",format="ALSA:pcm_s32le) to open with 32bit PCM in ffmpeg (default is pcm_s16le if not provided). Some audio devices fail to open with the default codec, hence this is a useful addition.
add PCM audio codec IDs
change Enum access syntax
|
Nice to see this getting in. I'm still in need for this feature actually 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #702 and #816
This enhancement lets user to specify any PCM audio codec to be used instead of relying on FFMPEG default (PCM_S16LE) when opening an audio device. Other than user preference, this is needed because some audio devices will not open with the default 16-bit codec e.g. some Focusrite Scarlett audio devices.
Usage:
Credits to @Kazhuu, @WyattBlue