Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis and Makefile #60

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Fix Travis and Makefile #60

merged 1 commit into from
Mar 8, 2019

Conversation

samsagaz
Copy link
Collaborator

@samsagaz samsagaz commented Mar 5, 2019

Arreglo de travis y Makefile.

NOTA: Prestar atención que hay tests que fallan.

@samsagaz
Copy link
Collaborator Author

samsagaz commented Mar 6, 2019

no funcionó el fix?

@eduzen
Copy link
Member

eduzen commented Mar 6, 2019

@samsagaz el pull esta perfecto, solo falla un test, pero no es parte de este issue. Habria que ver si en develop falla el test (si esta rama esta actualizada).
Pero yo lo mergearia @facundobatista

@eduzen eduzen self-requested a review March 6, 2019 18:31
@samsagaz
Copy link
Collaborator Author

samsagaz commented Mar 6, 2019

@eduzen !!!!! el test ya está arreglado en otro PR!

@samsagaz
Copy link
Collaborator Author

samsagaz commented Mar 6, 2019

Agrego....

Arregla #25 y #58, se deberían borrar los issues.

@eduzen
Copy link
Member

eduzen commented Mar 6, 2019

@eduzen !!!!! el test ya está arreglado en otro PR!

entonces mergeale esos fixes

@facundobatista facundobatista merged commit 9672a57 into PyAr:develop Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants