Fix a crash involving Uninferable args to namedtuple
#1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
DanielNoord
reviewed
Sep 4, 2022
Pull Request Test Coverage Report for Build 2989063289
💛 - Coveralls |
|
Should we close the pylint issue or leave it open for a duplicative test? |
I have recently been closing them directly. If there is nothing in |
DanielNoord
approved these changes
Sep 4, 2022
jacobtylerwalls
added
the
pylint-tested
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 5, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 5, 2022
osmocom-gerrit
pushed a commit
to osmocom/pysim
that referenced
this pull request
Sep 14, 2022
This reverts commit 12175d3. The upstream has fixed the regression: pylint-dev/pylint#7375 which was actually not in pylint itself but in its dependency: pylint-dev/astroid#1763 https://github.com/PyCQA/astroid/releases/tag/v2.12.6 Change-Id: I1bf36e0c6db14a10ff4eab57bae238401dbd7fd0 Closes: OS#5668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Previously, the namedtuple brain assumed that the second argument to
namedtuple()would be a container, but it could beUninferable. In the bug report, it was a dict comprehension relying on a function argument.Type of Changes
Related Issue
Closes pylint-dev/pylint#7375
Regression in 9531e03.