Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant W503 inline ignores #233

Merged
merged 1 commit into from Mar 20, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 17, 2022

We were already ignoring W503 in .flake8 since it conflicts with black. This PR cleans up the redundant inline ignores.

Also there was a note saying to keep .flake8 and setup.cfg in sync so I've also updated setup.cfg as well 馃槃

On a side note, I'm pretty sure we can get rid of .flake8 since flake8 can use setup.cfg fine when developing. Saves having to keep them in sync.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks for the cleanup!

@cooperlees cooperlees merged commit 83a8227 into PyCQA:master Mar 20, 2022
5 checks passed
@jpy-git jpy-git deleted the remove_redundant_w503_ignores branch March 20, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants