Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 621: Migrate to pyproject.toml #291

Merged
merged 5 commits into from Oct 3, 2022
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 23, 2022

Migrate to pyproject.toml using ini2toml to do the file conversion and running validate-pyproject in pre-commit to validate the results.

  • Comment out tool.setuptools.test-suite which was deprecated in setuptool v41.5.0
  • Currently flake8 is not compatible with pyproject.toml
  • Drop Python 3.6 and add Python 3.11 release candidate 2 -- https://www.python.org/download/pre-releases

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

  • I checked - flake8 is now >= 3.7 so happy to drop 3.6 finally.

Will leave up for at least 24 hours for some others to potentially comment.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
with:
python-version: 3.x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this default to that or did I break it? Happy to be more explicit here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be REQUIRED but perhaps they fixed it after user complaints. If your mods work then it is now optional.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pypa/bandersnatch/blob/main/.github/workflows/pypi_upload.yml#L18 - Ahh seems I did * here to get latest available python 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would actually autoupgrade to Python 4!!! You are brave. ;-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I roll forward and just fix when things break everywhere ... rather than pin and forget to move things like most people seem to prefer to do which I don't get ...

hypothesis
hypothesmith>=0.2
pre-commit

[flake8]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait for flake8 to support config in the toml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My sense is that will take time...

cclauss and others added 4 commits September 23, 2022 20:26
Correct.  It will.  I was a bit concerned about how long the 3.11 tests take.

Co-authored-by: Cooper Lees <me@cooperlees.com>
@cooperlees cooperlees merged commit 0fec7e5 into PyCQA:main Oct 3, 2022
6 checks passed
@cclauss cclauss deleted the pyproject.toml branch October 13, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants