Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tox config #294

Merged
merged 2 commits into from Oct 7, 2022
Merged

add tox config #294

merged 2 commits into from Oct 7, 2022

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Oct 3, 2022

I wrote a basic tox config when writing #281 as I was fighting with various version differences and kept failing the CI, and figured other people might find it useful as well.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, as much as I dislike too, I like it's helpfulness + uiquotious nature in the python OSS ecosystem so happy to use it here.

If you have time - Want to change our GitHub action to use it to so we know it's working? If not, I can eventually get to it.

@jakkdl
Copy link
Contributor Author

jakkdl commented Oct 4, 2022

Done! Looked around a bit and https://github.com/ymyzk/tox-gh-actions looked like the best way to do it. Also updated documentation and added tox to [dev], although it's somewhat redundant to have both tox and coverage+hypo*

Looks like wheel isn't needed to be installed in the CI anymore, though I admit I only found that out through brute force testing so maybe it's needed for some other reason.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's move to tox life.

@cooperlees cooperlees merged commit e12c12b into PyCQA:main Oct 7, 2022
6 checks passed
@jakkdl jakkdl deleted the tox branch October 17, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants