New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using set / dict comprehensions #51

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dmerejkowsky
Copy link

dmerejkowsky commented Aug 10, 2018

Stolen from pylint: https://github.com/PyCQA/pylint/blob/master/pylint/checkers/refactoring.py#L465

Some notes:

  • There's already a pull request adding a 009 check, it's fine if you want me change it to 010

  • I plan of "porting" more pylint warnings like this in the future (but don't worry, not everything at once!) Tell me if this OK with you.

@dmerejkowsky dmerejkowsky force-pushed the dmerejkowsky:consider-using-set-dict-comprehensions branch from 3c2d5e1 to 932eedc Aug 10, 2018

@dmerejkowsky

This comment has been minimized.

Copy link

dmerejkowsky commented Aug 10, 2018

Hum. It seems this is already done by https://pypi.org/project/flake8-comprehensions.

Feel free to close and sorry for the noise

@cooperlees

This comment has been minimized.

Copy link
Collaborator

cooperlees commented Aug 10, 2018

Many thanks for the idea and I understand why. Yes, flake8-comprehenions is awesome, I use it.

I think for bugbear, we actually want it to cause rather bad bugs in code to accept. Since we have another plugin that does this I will close it.

@cooperlees cooperlees closed this Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment