Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless sort in _style_guide_for #1628

Merged
merged 1 commit into from Jul 31, 2022
Merged

Remove needless sort in _style_guide_for #1628

merged 1 commit into from Jul 31, 2022

Conversation

mxr
Copy link
Contributor

@mxr mxr commented Jul 31, 2022

We are always returning the last element so a 'max' operation is sufficient instead of sorting. Note the old code did not handle an empty list so this change doesn't either

We are always returning the last element so a 'max' operation is sufficient instead of sorting. Note the old code did not handle an empty list so this change doesn't either
@asottile asottile merged commit 3f4872a into PyCQA:main Jul 31, 2022
11 checks passed
@mxr mxr deleted the patch-1 branch Jul 31, 2022
@asottile asottile added this to the 5.0.1 milestone Jul 31, 2022
@mxr
Copy link
Contributor Author

mxr commented Aug 1, 2022

🎵 I miss the old Tony, posts cat gifs when you merge Tony 🎶

@asottile
Copy link
Member

asottile commented Aug 1, 2022

🎵 I miss the old Tony, posts cat gifs when you merge Tony 🎶

my script is broken :'( -- stupid SPAs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants