Python 3.13 support by mayty · Pull Request #2306 · PyCQA/isort

mayty · 2024-11-22T12:57:57Z

Related issue: 2305

king-phyte · 2024-12-06T13:56:14Z

Since 3.8 is EOL, shouldn't we drop support for that too?

mayty · 2024-12-09T18:12:07Z

I think that Python 3.8 doesn't conflict with adding Python 3.13 support and dropping it is outside of this PR's scope

king-phyte · 2024-12-09T20:21:30Z

Fair point :)

hugovk · 2024-12-26T09:32:22Z

isort/stdlibs/py312.py

    "argparse",
    "array",
    "ast",
+    "asynchat",


Please remove these.

They were all removed in 3.12:

https://docs.python.org/3/whatsnew/3.12.html#asynchat-and-asyncore

I can remove it, but it was added by the scripts. So it will automatically appear on the next run because it's still present in the corresponding documentation: https://docs.python.org/3.12/library/asynchat.html#module-asynchat

Mb it would be better to use stdlibs package or adopt it's approach to modules generation?

Aha, the problem was caused by the docs re-adding module pages which had bee removed, but as stubs:

python/cpython#126622

Mb it would be better to use stdlibs package or adopt it's approach to modules generation?

Yeah, sounds like a good idea to use stdlibs 👍

updated the script to use stdlibs and ran it

hugovk · 2024-12-26T09:33:48Z

isort/stdlibs/py313.py

+    "argparse",
+    "array",
+    "ast",
+    "asynchat",


Similarly, this list contains lots of modules that have been removed in 3.12 or earlier.

Was this list created using the mkstdlibs.py script?

all changes to stdlibbs/py*.py were generated by mkstdlibs.py scripts

use `stdlibs` for stdlibs packages list

hugovk

Thank you!

DanielNoord · 2025-01-09T08:37:31Z

Awesome! Could you rebase this so we can get this merged?

Issue/2305 pull upstream

mayty · 2025-01-09T19:34:05Z

I had to drop python3.8 support to make builds pass on python3.13 because some packages required a version, which do not support python3.8 (not sure how it passed before the make actions happy PR merge)

At the same time, the prod package could have been installed with both 3.8 and 3.13, so I'm open to rolling back this commit if 3.8 support is considered more important than builds with python3.13 in PRs

hugovk · 2025-01-09T19:39:41Z

I think it's fine to drop 3.8, as mentioned before, it's already EOL:

We could merge this as-is and do a more thorough 3.8 cleanup in another PR.

DanielNoord · 2025-01-10T13:45:37Z

@mayty This can be rebased on main again :) Sorry for the churn! Just taking things slow.

Issue/2305 pull upstream

DanielNoord · 2025-01-11T07:48:32Z

See PyCQA/meta#64 (comment) I have stopped merging anything.

codecov · 2025-01-14T19:12:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (26cf27d) to head (87d592e).
Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          39       40    +1     
  Lines        3095     3096    +1     
  Branches      787      787           
=======================================
+ Hits         3068     3069    +1     
  Misses         15       15           
  Partials       12       12

staticdev

@mayty thanks a lot for your contribution. Your changes look good to me. I kindly ask to rebase again and generate a new poetry.lock. The integration tests were failing and I just merged #2329.

Also, since you are supporting a higher version on Python, I also suggest to increase the integration tests version up to 3.12 on .github/workflows/integration.yml.

DanielNoord

@staticdev Pushed the changes you requested to help move this along :)

There are two more remaining questions from my side. Other than that I think also think this looks good.

poetry.lock

DanielNoord · 2025-01-14T19:49:41Z

pyproject.toml

 types-colorama = ">=0.4.2"
 types-toml = ">=0.1.3"
 vulture = ">=1.0"
+stdlibs = ">=2024.10.21.16"


It seems as if [tool.poetry.dev-dependencies] is almost in alphabetical order. Not sure if we want to add a commit to do so.

I'm all for alphabetical order, but only if there is gonna be a commitment to maintaining it in the future (at least a mention in the coding-standart doc)

Up to @staticdev

+1 for alhabetical order.. I normally have in all project I maintain.

Sorted dev dependencies

DanielNoord

Awesome!

staticdev

LGTM.

staticdev · 2025-01-15T19:23:31Z

Thanks @mayty @DanielNoord @hugovk

python 3.13 support

1a90943

mayty marked this pull request as ready for review November 22, 2024 13:02

hugovk suggested changes Dec 26, 2024

View reviewed changes

pik.paval and others added 2 commits December 27, 2024 23:32

use stdlibs for stdlibs packages list

b35f782

Merge pull request #1 from mayty/issue/2305_new_mkstdlibs

d49bb41

use `stdlibs` for stdlibs packages list

hugovk approved these changes Dec 28, 2024

View reviewed changes

DanielNoord mentioned this pull request Jan 9, 2025

PyCQA/isort triage PyCQA/meta#64

Closed

pik.paval and others added 3 commits January 9, 2025 20:19

resolve merge conflict

aafed6a

Allow python3.13 dev install at the cost of dropping python 3.8 support

1f6586d

Merge pull request #2 from mayty/issue/2305_pull_upstream

99cd8d4

Issue/2305 pull upstream

DanielNoord mentioned this pull request Jan 9, 2025

Remove support for Python 3.8 #2327

Merged

pik.paval and others added 2 commits January 10, 2025 20:36

resolve merge conflict

99dfe9d

Merge pull request #3 from mayty/issue/2305_pull_upstream

a20fb40

Issue/2305 pull upstream

staticdev requested changes Jan 14, 2025

View reviewed changes

DanielNoord added 3 commits January 14, 2025 20:43

Merge branch 'main' of https://github.com/PyCQA/isort into issue/2305

1ff8eec

Update hash of lock file

fce7b4d

Bump CI Python versions to 3.12

b6d01c9

DanielNoord reviewed Jan 14, 2025

View reviewed changes

DanielNoord requested a review from staticdev January 14, 2025 19:53

DanielNoord mentioned this pull request Jan 14, 2025

Use sys.stdlib_module_names to complement known stdlib modules #2295

Open

sort dev dependencies

87d592e

DanielNoord approved these changes Jan 15, 2025

View reviewed changes

staticdev approved these changes Jan 15, 2025

View reviewed changes

staticdev merged commit 724d5e0 into PyCQA:main Jan 15, 2025
21 checks passed

DanielNoord mentioned this pull request Jan 20, 2025

Python 3.13 support #2305

Closed

Uh oh!

Conversation

mayty commented Nov 22, 2024

Uh oh!

king-phyte commented Dec 6, 2024

Uh oh!

mayty commented Dec 9, 2024

Uh oh!

king-phyte commented Dec 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

DanielNoord commented Jan 9, 2025

Uh oh!

mayty commented Jan 9, 2025

Uh oh!

hugovk commented Jan 9, 2025

Uh oh!

DanielNoord commented Jan 10, 2025

Uh oh!

DanielNoord commented Jan 11, 2025

Uh oh!

codecov bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

staticdev left a comment

Choose a reason for hiding this comment

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

staticdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

staticdev commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 14, 2025 •

edited

Loading