Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 40 40
Lines 3101 3101
Branches 680 680
=======================================
Hits 3075 3075
Misses 15 15
Partials 11 11 🚀 New features to boost your workflow:
|
DanielNoord
approved these changes
Mar 5, 2025
staticdev
reviewed
Mar 17, 2025
kurtmckee
force-pushed
the
bandit-warnings
branch
from
860af9f to
3cde306
Compare
staticdev
requested changes
Mar 18, 2025
staticdev
reviewed
Mar 18, 2025
The `nosec` flags benefit from human-readable explanation, but bandit was seeing the trailing text and throwing warnings: ``` WARNING Test in comment: Needed is not a test name or id, ignoring WARNING Test in comment: for is not a test name or id, ignoring WARNING Test in comment: gitignore is not a test name or id, ignoring WARNING Test in comment: support is not a test name or id, ignoring ``` This is addressed by using another `#` character to hide the text.
staticdev
force-pushed
the
bandit-warnings
branch
from
2e26b8b to
e42578f
Compare
staticdev
approved these changes
Mar 22, 2025
Collaborator
staticdev
left a comment
staticdev
left a comment
There was a problem hiding this comment.
LGTM @kurtmckee, thanks.
Contributor
Author
|
Friendly ping. 😁 |
Collaborator
|
@kurtmckee forgot to click merge haha |
luketainton
pushed a commit
to luketainton/repos_roboluke
that referenced
this pull request
Oct 2, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [isort](https://github.com/PyCQA/isort) ([changelog](https://github.com/PyCQA/isort/releases)) | `<6.1.0,>=6.0.0` -> `<6.1.1,>=6.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>PyCQA/isort (isort)</summary> ### [`v6.1.0`](https://github.com/PyCQA/isort/releases/tag/6.1.0) [Compare Source](PyCQA/isort@6.0.1...6.1.0) #### Changes - Update docs discussions channel ([#​2410](PyCQA/isort#2410)) [@​staticdev](https://github.com/staticdev) - Add python 3.14 classifier and badge ([#​2409](PyCQA/isort#2409)) [@​staticdev](https://github.com/staticdev) - Drop use of non-standard pkg\_resources API ([#​2405](PyCQA/isort#2405)) [@​dvarrazzo](https://github.com/dvarrazzo) - Use working isort version in pre-commit example ([#​2402](PyCQA/isort#2402)) [@​iainelder](https://github.com/iainelder) - fix typo in \_get\_files\_from\_dir\_cached test ([#​2392](PyCQA/isort#2392)) [@​tiltingpenguin](https://github.com/tiltingpenguin) - Resolve bandit warnings ([#​2379](PyCQA/isort#2379)) [@​kurtmckee](https://github.com/kurtmckee) - Add tox for cross-platform, parallel test suite execution ([#​2378](PyCQA/isort#2378)) [@​kurtmckee](https://github.com/kurtmckee) - Add Project URLs to PyPI Side Panel ([#​2387](PyCQA/isort#2387)) [@​guillermodotn](https://github.com/guillermodotn) - Fix typos ([#​2376](PyCQA/isort#2376)) [@​co63oc](https://github.com/co63oc) #### :construction\_worker: Continuous Integration - Add make bash scripts portable ([#​2377](PyCQA/isort#2377)) [@​staticdev](https://github.com/staticdev) #### 📦 Dependencies - Bump actions/checkout from 4 to 5 in the github-actions group ([#​2406](PyCQA/isort#2406)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) - Bump astral-sh/setup-uv from 5 to 6 in the github-actions group ([#​2395](PyCQA/isort#2395)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzIuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/380 Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk> Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_epage
that referenced
this pull request
Oct 7, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [isort](https://github.com/PyCQA/isort) ([changelog](https://github.com/PyCQA/isort/releases)) | `<6.1.0,>=6.0.0` -> `<6.1.1,>=6.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>PyCQA/isort (isort)</summary> ### [`v6.1.0`](https://github.com/PyCQA/isort/releases/tag/6.1.0) [Compare Source](PyCQA/isort@6.0.1...6.1.0) #### Changes - Update docs discussions channel ([#​2410](PyCQA/isort#2410)) [@​staticdev](https://github.com/staticdev) - Add python 3.14 classifier and badge ([#​2409](PyCQA/isort#2409)) [@​staticdev](https://github.com/staticdev) - Drop use of non-standard pkg\_resources API ([#​2405](PyCQA/isort#2405)) [@​dvarrazzo](https://github.com/dvarrazzo) - Use working isort version in pre-commit example ([#​2402](PyCQA/isort#2402)) [@​iainelder](https://github.com/iainelder) - fix typo in \_get\_files\_from\_dir\_cached test ([#​2392](PyCQA/isort#2392)) [@​tiltingpenguin](https://github.com/tiltingpenguin) - Resolve bandit warnings ([#​2379](PyCQA/isort#2379)) [@​kurtmckee](https://github.com/kurtmckee) - Add tox for cross-platform, parallel test suite execution ([#​2378](PyCQA/isort#2378)) [@​kurtmckee](https://github.com/kurtmckee) - Add Project URLs to PyPI Side Panel ([#​2387](PyCQA/isort#2387)) [@​guillermodotn](https://github.com/guillermodotn) - Fix typos ([#​2376](PyCQA/isort#2376)) [@​co63oc](https://github.com/co63oc) #### :construction\_worker: Continuous Integration - Add make bash scripts portable ([#​2377](PyCQA/isort#2377)) [@​staticdev](https://github.com/staticdev) #### 📦 Dependencies - Bump actions/checkout from 4 to 5 in the github-actions group ([#​2406](PyCQA/isort#2406)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) - Bump astral-sh/setup-uv from 5 to 6 in the github-actions group ([#​2395](PyCQA/isort#2395)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzIuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/epage/pulls/164 Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk> Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_webexmemebot
that referenced
this pull request
Jan 5, 2026
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [isort](https://github.com/PyCQA/isort) ([changelog](https://github.com/PyCQA/isort/releases)) | `<6.1.0,>=6.0.0` -> `<6.1.1,>=6.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>PyCQA/isort (isort)</summary> ### [`v6.1.0`](https://github.com/PyCQA/isort/releases/tag/6.1.0) [Compare Source](PyCQA/isort@6.0.1...6.1.0) #### Changes - Update docs discussions channel ([#​2410](PyCQA/isort#2410)) [@​staticdev](https://github.com/staticdev) - Add python 3.14 classifier and badge ([#​2409](PyCQA/isort#2409)) [@​staticdev](https://github.com/staticdev) - Drop use of non-standard pkg\_resources API ([#​2405](PyCQA/isort#2405)) [@​dvarrazzo](https://github.com/dvarrazzo) - Use working isort version in pre-commit example ([#​2402](PyCQA/isort#2402)) [@​iainelder](https://github.com/iainelder) - fix typo in \_get\_files\_from\_dir\_cached test ([#​2392](PyCQA/isort#2392)) [@​tiltingpenguin](https://github.com/tiltingpenguin) - Resolve bandit warnings ([#​2379](PyCQA/isort#2379)) [@​kurtmckee](https://github.com/kurtmckee) - Add tox for cross-platform, parallel test suite execution ([#​2378](PyCQA/isort#2378)) [@​kurtmckee](https://github.com/kurtmckee) - Add Project URLs to PyPI Side Panel ([#​2387](PyCQA/isort#2387)) [@​guillermodotn](https://github.com/guillermodotn) - Fix typos ([#​2376](PyCQA/isort#2376)) [@​co63oc](https://github.com/co63oc) #### :construction\_worker: Continuous Integration - Add make bash scripts portable ([#​2377](PyCQA/isort#2377)) [@​staticdev](https://github.com/staticdev) #### 📦 Dependencies - Bump actions/checkout from 4 to 5 in the github-actions group ([#​2406](PyCQA/isort#2406)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) - Bump astral-sh/setup-uv from 5 to 6 in the github-actions group ([#​2395](PyCQA/isort#2395)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzIuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/webexmemebot/pulls/510 Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk> Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nosecflags benefit from human-readable explanation, but bandit was seeing the trailing text and throwing warnings:This is addressed by using another
#character to hide the text.