Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt and Pipfile support #715

Merged
merged 15 commits into from Sep 23, 2018
Merged

Conversation

@orsinium
Copy link
Contributor

@orsinium orsinium commented Jun 22, 2018

  1. Split place_module to separated classes named "finders". It's make developing and extending easier.
  2. Move some operations from "parse_module" stage to "init".
  3. Add finder for Pipfile via requirementslib (part of pipenv)
  4. Add finder for requirements.txt via pip.
  5. Both finders (requirements and pipfile) uses pipreqs for converting PyPI package name to module name.

Fix #459

@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Jul 30, 2018

@timothycrosley, can you review my pull request?

@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Aug 8, 2018

@timothycrosley , do you alive?

@timothycrosley
Copy link
Member

@timothycrosley timothycrosley commented Sep 23, 2018

Sorry for the long delay, reviewing now and it looks great! Merging, thanks for the great work

@timothycrosley timothycrosley merged commit 786da86 into PyCQA:develop Sep 23, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@n6g7
Copy link

@n6g7 n6g7 commented Sep 29, 2018

Can't wait to use that!
@timothycrosley When can we expect a new release? 🙂

@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Sep 29, 2018

@n6g7, as temporary solution you can use my fork:

pip install isort-plus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants