Update pep8-naming compatibility with flake8
#210
Conversation
|
Let me know what you think of the changes! I resolved the discussions that I assumed the decision & action was clear; please resolve/elaborate on the |
There was a problem hiding this comment.
There appear to be text failures related to the new tox.ini dependency matrix. I'm not able to look more closely at the moment, so would you be able to give those a look @stdedos?
If you'd like to just bump the install_requires dependency as its own change, I'd be glad to approve that separately.
If "proving actually" that v3/v4 is not supported while doing the change itself, I could do it. Although, I'd guesstimate it will be equivalent effort to do either. |
Oh yeah! Here's my v6 problem: https://github.com/PyCQA/pep8-naming/actions/runs/3702319329/jobs/6289277028 😛 |
`pep8-naming` tests fail for `flake8` v3/v4; avoid suggesting that it works. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
* No `requirements.txt` file * No `install_requires` upper limit on `flake8` Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
* `py37` has no `flake8 v6` * `flake8.options.manager.OptionManager` seems to require a `formatter_names` `kwarg` PyCQA/flake8@48b2919 etc seem to indicate that `[]` is what we need, "since we are not a formatter library" (Documentation https://flake8.pycqa.org/en/latest/internal/option_handling.html seems non-existent) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos
force-pushed
the
test/flake8-fix-compatibility
branch
from
086f02f
to
154683d
Compare
|
Someone pls workflows 🙏 |
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
|
I assumed that |
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
|
Finally CI likes my changes 🎉 🚀 |
Additionally, rename `flake8#` to `flake8-v#` Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
pep8-namingtests fail forflake8v3/v4; avoid suggesting that it worksAdditionally, v6 added one more required
kwarg. Let's add that one too.Signed-off-by: Stavros Ntentos 11300730-stavros-relex@users.noreply.gitlab.com