Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--match_dir does not work properly #108

Closed
glennmatthews opened this issue Feb 19, 2015 · 0 comments · Fixed by #109
Closed

--match_dir does not work properly #108

glennmatthews opened this issue Feb 19, 2015 · 0 comments · Fixed by #109

Comments

@glennmatthews
Copy link
Contributor

@glennmatthews glennmatthews commented Feb 19, 2015

The --match_dir is not respected properly when multiple directories exist:

> mkdir bar
> mkdir bat
> mkdir baz
> touch bar/bar.py
> touch bat/bat.py
> touch baz/baz.py
> pep257 --match-dir=bar
./bar/bar.py:1 at module level:
        D100: Docstring missing
./baz/baz.py:1 at module level:
        D100: Docstring missing

bar is correctly matched, and bat is correctly excluded, but baz is incorrectly included.

I have a candidate fix for this - will submit pull request.

glennmatthews added a commit to glennmatthews/pep257 that referenced this issue Feb 19, 2015
@glennmatthews glennmatthews changed the title --match_dir does not work properly --match_dir does not work properly Feb 19, 2015
@Nurdok Nurdok closed this in #109 Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant