New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path to file is lowercased #179

Closed
BrnoPCmaniak opened this Issue Mar 26, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@BrnoPCmaniak
Copy link

BrnoPCmaniak commented Mar 26, 2016

When I enter full path to file in output the path is lowecased. This leads to errors in for example atom-pydocstyle because it opens files which don't exists.

[fdobrovolny@minos sis]$ pydocstyle /home/fdobrovolny/DEV/sis/.../function_based.py
/home/fdobrovolny/dev/sis/.../function_based.py:12 in public function `paginate`:
        D400: First line should end with a period (not 's')

(...=path is shortened)

[fdobrovolny@minos sis]$ pydocstyle --version
1.0.0
@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Mar 26, 2016

Thanks for reporting this, I'll try to get on it as soon as I can, but it will probably take me a few days.
Also, I didn't know about linter-pydocstyle. Awesome!

@sigmavirus24

This comment has been minimized.

Copy link
Member

sigmavirus24 commented Mar 26, 2016

From what I can tell, pydocstyle opens the file without changing the casing. I think pydocstyle is just lower-casing the path when it prints it though. Is that what is causing problems for atom-pydocstyle?

@BrnoPCmaniak

This comment has been minimized.

Copy link

BrnoPCmaniak commented Mar 26, 2016

@sigmavirus24 yes, excatly that's the problem.

sigmavirus24 added a commit to sigmavirus24/pep257 that referenced this issue Mar 26, 2016

Stop converting the filename to lowercase
This leads to problems for tools integrating with pydocstyle, e.g., atom
linter-pydocstyle

Closes PyCQA#179
@sigmavirus24

This comment has been minimized.

Copy link
Member

sigmavirus24 commented Mar 26, 2016

I've submitted #181 which I think fixes this. Please try it out @BrnoPCmaniak (you may also need PR #180 for it to work though).

@BrnoPCmaniak

This comment has been minimized.

Copy link

BrnoPCmaniak commented Mar 26, 2016

@sigmavirus24 works 100% thanks a lot.

@sigmavirus24

This comment has been minimized.

Copy link
Member

sigmavirus24 commented Mar 26, 2016

I think @Nurdok might want to leave this open until that's merged. Thanks for confirming though @BrnoPCmaniak

@sigmavirus24 sigmavirus24 reopened this Mar 26, 2016

sigmavirus24 added a commit to sigmavirus24/pep257 that referenced this issue Mar 27, 2016

Stop converting the filename to lowercase
This leads to problems for tools integrating with pydocstyle, e.g., atom
linter-pydocstyle

Closes PyCQA#179

@Nurdok Nurdok closed this in #181 Apr 4, 2016

@Nurdok Nurdok added this to the pydocstyle 1.1.0 milestone Jul 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment