New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--source is broken #256

Closed
brbsix opened this Issue May 8, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@brbsix
Copy link
Contributor

brbsix commented May 8, 2017

The --source option is broken. Output looks like:

src/pydocstyle/violations.py:87 in public method `__lt__`:
	    D105: Missing docstring in magic method

876:     def __lt__(self, other):
	87:     def __lt__(self, other):
886:         return (self.filename, self.line) < (other.filename, other.line)
	88:         return (self.filename, self.line) < (other.filename, other.line)

When it (presumably) should look like:

src/pydocstyle/violations.py:87 in public method `__lt__`:
	    D105: Missing docstring in magic method

87:     def __lt__(self, other):
88:         return (self.filename, self.line) < (other.filename, other.line)

The issue originates in Errors.lines, found here: https://github.com/PyCQA/pydocstyle/blob/master/src/pydocstyle/violations.py#L49

It looks like some code may have been committed accidentally before it was complete.

@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Jun 10, 2017

Fixed by #260 .

@Nurdok Nurdok closed this Jun 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment