Support '.pep257rc' as a configuration filename #140

Merged
merged 1 commit into from Oct 20, 2015

Projects

None yet

2 participants

@jacebrowning
Contributor

PEP8 and PyLint use .pep8rc and .pylintrc, respectively, so I thought it would be good for PEP257 to support the “rc” convention as well.

@jacebrowning jacebrowning Support '.pep257rc' as a configuration filename
PEP8 and PyLint use `.pep8rc` and `.pylintrc`, respectively, so I
thought it would be good for PEP257 to support the “rc” convention as
well.
deebc81
@jacebrowning
Contributor

The same result could be achieved if #117 were implemented.

@Nurdok
Member
Nurdok commented Oct 12, 2015

pep8 doesn't seem to support pep8rc. In their documentation (http://pep8.readthedocs.org/en/latest/intro.html#configuration) they only state support in .pep8, tox.ini and setup.cfg, which is the same as pep257 (while obviously supporting .pep257 instead of .pep8). Pylint supports only pylintrc, which makes me think that pep257 is more similar to pep8 in this regard.

For these reasons, I'm inclined to not merge this PR, but feel free to try and convince me otherwise :)

@jacebrowning
Contributor

I also just noticed that naming the file .pep8 is deprecated. My main argument for using .<tool>rc verses .tool is that the former is clearly user configuration while the latter could possibly be a temporary file/directory used by that tool.

@Nurdok Nurdok merged commit 20dc16f into PyCQA:master Oct 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nurdok
Member
Nurdok commented Oct 20, 2015

Okay, I don't see too much harm in this. Merged.

@jacebrowning
Contributor

Thanks!

@jacebrowning jacebrowning deleted the unknown repository branch Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment