Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '.pep257rc' as a configuration filename #140

Merged
merged 1 commit into from Oct 20, 2015
Merged

Support '.pep257rc' as a configuration filename #140

merged 1 commit into from Oct 20, 2015

Conversation

@jacebrowning
Copy link
Contributor

@jacebrowning jacebrowning commented Oct 9, 2015

PEP8 and PyLint use .pep8rc and .pylintrc, respectively, so I thought it would be good for PEP257 to support the “rc” convention as well.

PEP8 and PyLint use `.pep8rc` and `.pylintrc`, respectively, so I
thought it would be good for PEP257 to support the “rc” convention as
well.
@jacebrowning
Copy link
Contributor Author

@jacebrowning jacebrowning commented Oct 9, 2015

The same result could be achieved if #117 were implemented.

@Nurdok
Copy link
Member

@Nurdok Nurdok commented Oct 12, 2015

pep8 doesn't seem to support pep8rc. In their documentation (http://pep8.readthedocs.org/en/latest/intro.html#configuration) they only state support in .pep8, tox.ini and setup.cfg, which is the same as pep257 (while obviously supporting .pep257 instead of .pep8). Pylint supports only pylintrc, which makes me think that pep257 is more similar to pep8 in this regard.

For these reasons, I'm inclined to not merge this PR, but feel free to try and convince me otherwise :)

@jacebrowning
Copy link
Contributor Author

@jacebrowning jacebrowning commented Oct 12, 2015

I also just noticed that naming the file .pep8 is deprecated. My main argument for using .<tool>rc verses .tool is that the former is clearly user configuration while the latter could possibly be a temporary file/directory used by that tool.

Nurdok added a commit that referenced this issue Oct 20, 2015
Support '.pep257rc' as a configuration filename
@Nurdok Nurdok merged commit 20dc16f into PyCQA:master Oct 20, 2015
1 check passed
@Nurdok
Copy link
Member

@Nurdok Nurdok commented Oct 20, 2015

Okay, I don't see too much harm in this. Merged.

@jacebrowning
Copy link
Contributor Author

@jacebrowning jacebrowning commented Oct 20, 2015

Thanks!

@jacebrowning jacebrowning deleted the rc-config-file branch Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants