Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent AssertionError parsing __future__ import #154

Merged
merged 1 commit into from Nov 11, 2015

Conversation

Projects
None yet
2 participants
@jayvdb
Copy link
Contributor

commented Oct 28, 2015

The future import parser introduced in 0.7.0 would cause
pep257 to crash with an AssertionError for some obscure
valid syntax, and many invalid syntax.

Fixes #153.

Prevent AssertionError parsing __future__ import
The __future__ import parser introduced in 0.7.0 would cause
pep257 to crash with an AssertionError for some obscure
valid syntax, and many invalid syntax.
@Nurdok

This comment has been minimized.

Copy link
Member

commented Nov 4, 2015

Hey guys, I saw a bunch of PRs were opened. I just wanted to let you know it'll take me a week or two to get around to review them. Don't despair, and thanks for the effort!

Nurdok added a commit that referenced this pull request Nov 11, 2015

Merge pull request #154 from jayvdb/harden_future_import_parser
Prevent AssertionError parsing __future__ import

@Nurdok Nurdok merged commit d0022d8 into PyCQA:master Nov 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nurdok

This comment has been minimized.

Copy link
Member

commented Nov 11, 2015

Thanks for this PR! I'm sorry it took me so long to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.