This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Check for D302 if at Python 3.3+ and using explicit unicode prefix. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not is_ascii(docstring) and not docstring.startswith( | ||
| ('u', 'ur')): | ||
| if docstring and not docstring.startswith('u'): | ||
| if sys.version_info < (3, 0) and not is_ascii(docstring): |
There was a problem hiding this comment.
Since this would add the first runtime dependency to the project, and thus break its advertised self-containedness, I suggest you integrate the library as you best see fit. I will then rebase / adjust the PR accordingly. However, I think the benefit at this particular location would by marginally, as six does not offer minor version (range) distinction.
|
This PR has not had any updates in 3 years. Closing this for now. If there's any interest in resuming this, feel free to reopen. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.3, Unicode string literal prefixes have been reintroduced, but D302 is exclusively reported for Python 2.
This proposes an implementation to report D302 if and only if a Unicode prefix has been explicitly added to the docstring for Python 3. The behavior of D302 for Python 2 is not changed.
This also adds some test cases to the already existing Unicode integration test (pypy3 currently implements Python 3.2, only). To avoid code duplication, this has been implemented as a single test case with multiple checks. Let me know if you would like to see those in separate tests.