New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop converting the filename to lowercase #181

Merged
merged 3 commits into from Apr 4, 2016

Conversation

Projects
None yet
3 participants
@sigmavirus24
Copy link
Member

sigmavirus24 commented Mar 26, 2016

This leads to problems for tools integrating with pydocstyle, e.g., atom
linter-pydocstyle

Closes #179

cc @BrnoPCmaniak

@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Mar 26, 2016

Notice that the tests fail for the PR - see the Travis build.
Also, this should be checked on a Windows machine - I think the lower call was made because there were "c:" - "C:" incosistencies. I'll have to check this later.

@sigmavirus24

This comment has been minimized.

Copy link
Member

sigmavirus24 commented Mar 27, 2016

Notice that the tests fail for the PR - see the Travis build.

I did notice that and I was attempting to determine why before I had to leave yesterday. :)

Also, this should be checked on a Windows machine

Should we attempt to set up AppVeyor for pydocstyle?

For whatever it may be worth, pycodestyle doesn't munge the paths for case sensitivity and doesn't appear to have problems on Windows.

sigmavirus24 added some commits Mar 26, 2016

Stop converting the filename to lowercase
This leads to problems for tools integrating with pydocstyle, e.g., atom
linter-pydocstyle

Closes #179
Fix pytest warning in integration tests
Also using -rw as an additional option to pytest will always print warnings
for us

@sigmavirus24 sigmavirus24 force-pushed the sigmavirus24:bug/179 branch from 21b7537 to d99705e Mar 27, 2016

@sigmavirus24

This comment has been minimized.

Copy link
Member

sigmavirus24 commented Mar 27, 2016

So I updated the test case that was failing. I also updated the tests for a few things I noticed (that I'll happily pull into a separate pull request) including parametrizing the test that was failing and fixing a warning that pytest wasn't printing by default (and printing pytest warings by default).

@@ -21,7 +21,7 @@
__all__ = ()


class TestEnv(object):
class FakeTestEnv(object):

This comment has been minimized.

@Nurdok

Nurdok Apr 2, 2016

Member

Why this name change?

This comment has been minimized.

@sigmavirus24

sigmavirus24 Apr 2, 2016

Member

So I'm happy to pull d99705e into a separate pull request. I just noticed it and fixed it while working on this.

This comment has been minimized.

@Nurdok

Nurdok Apr 2, 2016

Member

Oh, this is because pytest tries to collect this class? Then it's fine to change the name. However, I don't like "fake" because is creates a real file system environment. How about InvocationEnv / StagingEnv / DeployEnv, etc.?

This comment has been minimized.

@The-Compiler

The-Compiler Apr 3, 2016

Contributor

Yup - pytest tries to collect classes named Test*

@Nurdok Nurdok merged commit d99705e into PyCQA:master Apr 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Apr 4, 2016

I merged this manually and changed FakeTestEnv to SandboxEnv. Thanks!

@sigmavirus24

This comment has been minimized.

Copy link
Member

sigmavirus24 commented Apr 4, 2016

Sorry about that. I was going to get to it tonight. :)

@sigmavirus24 sigmavirus24 deleted the sigmavirus24:bug/179 branch Apr 4, 2016

@blueyed blueyed referenced this pull request Jun 26, 2016

Closed

New bugfix release #194

@Nurdok Nurdok added this to the pydocstyle 1.1.0 milestone Jul 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment