New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print errors to stdout #210

Merged
merged 3 commits into from Oct 25, 2016

Conversation

Projects
2 participants
@varunagrawal
Copy link
Contributor

varunagrawal commented Oct 7, 2016

Fixes for #201

@varunagrawal varunagrawal force-pushed the varunagrawal:hacktoberfest branch from e290ed8 to a7cb649 Oct 7, 2016

@varunagrawal varunagrawal referenced this pull request Oct 10, 2016

Closed

Wildcard ignore #72

@varunagrawal varunagrawal changed the title Print errors to stdout Hacktoberfest PR (multiple features) Oct 10, 2016

@varunagrawal varunagrawal force-pushed the varunagrawal:hacktoberfest branch from e1764f6 to d7726cf Oct 10, 2016

@varunagrawal varunagrawal changed the title Hacktoberfest PR (multiple features) Print errors to stdout Oct 10, 2016

@varunagrawal varunagrawal referenced this pull request Oct 10, 2016

Closed

Ignore Wildcard #212

@@ -53,7 +53,7 @@ def run_pydocstyle(use_pep257=False):

count = 0
for error in errors:
sys.stderr.write('%s\n' % error)
sys.stdout.write('%s\n' % error)

This comment has been minimized.

@Nurdok

Nurdok Oct 13, 2016

Member

Now that errors are prints to stdout, notice that the test for --count in test_integration.py needs to be made more robust.

This comment has been minimized.

@varunagrawal

varunagrawal Oct 17, 2016

Contributor

How would you suggest I go about doing this?

This comment has been minimized.

@Nurdok

Nurdok Oct 23, 2016

Member

Instead of checking that the count number is somewhere in the output, check that it's the last line of stdout.

This comment has been minimized.

@varunagrawal

@varunagrawal varunagrawal force-pushed the varunagrawal:hacktoberfest branch from d7726cf to ffb2383 Oct 17, 2016

@@ -53,7 +53,7 @@ def run_pydocstyle(use_pep257=False):

count = 0
for error in errors:
sys.stderr.write('%s\n' % error)
sys.stdout.write('%s\n' % error)

This comment has been minimized.

@Nurdok

Nurdok Oct 23, 2016

Member

Instead of checking that the count number is somewhere in the output, check that it's the last line of stdout.

@Nurdok

Nurdok approved these changes Oct 25, 2016

@Nurdok Nurdok merged commit 7e0c3f4 into PyCQA:master Oct 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Oct 25, 2016

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment