Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip whitespace in _fix_set_options #221

Closed
wants to merge 1 commit into from

Conversation

@blueyed
Copy link
Contributor

blueyed commented Nov 22, 2016

This allows to specify e.g. "ignore" on multiple lines, without adding
additional commas:

[pydocstyle]
ignore = D100,D101,D102,D103,
  # "1 blank line required before class docstring"
  # Disabled by default, conflicts with D211.
  D203,
  # "Multi-line docstring summary should start at the second line" (vs. D212).
  D213,

Currently you would have to use:

ignore = D100,
    ,D101,
    ,D102,

TODO:

  • doc
  • test
This allows to specify e.g. "ignore" on multiple lines, without adding
additional commas:

    [pydocstyle]
    ignore = D100,D101,D102,D103,
      # "1 blank line required before class docstring"
      # Disabled by default, conflicts with D211.
      D203,
      # "Multi-line docstring summary should start at the second line" (vs. D212).
      D213,
@@ -465,10 +465,10 @@ def _fix_set_options(options):
def _get_set(value_str):
"""Split `value_str` by the delimiter `,` and return a set.
Removes any occurrences of '' in the set.
Removes empty values ('') and strips whitespace.

This comment has been minimized.

Copy link
@Nurdok

Nurdok Nov 23, 2016

Member

Please add a test for this.

@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Nov 30, 2019

I'm closing this PR as part of cleaning up stale issues and PRs. Feel free to open if you believe this is still relevant. Thanks!

@Nurdok Nurdok closed this Nov 30, 2019
@blueyed

This comment has been minimized.

Copy link
Contributor Author

blueyed commented Nov 30, 2019

I cannot reopen it myself.
Please do so, will add the test.

@blueyed

This comment has been minimized.

Copy link
Contributor Author

blueyed commented Nov 30, 2019

=> #431

@blueyed blueyed deleted the blueyed:allow-multiline-config branch Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.