New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules starting with a single leading underscore are considered private #222

Merged
merged 3 commits into from Dec 2, 2016

Conversation

Projects
None yet
2 participants
@Nurdok
Copy link
Member

Nurdok commented Nov 27, 2016

Solves #199

  • Add docs
  • Update release notes

@Nurdok Nurdok added the Bugfix label Nov 27, 2016

@Nurdok Nurdok self-assigned this Nov 27, 2016

_nest = staticmethod(lambda s: {'def': Function, 'class': Class}[s])
module = property(lambda self: self)
all = property(lambda self: self._all)

@property
def is_public(self):
return not self.name.startswith('_') or self.name.startswith('__')

This comment has been minimized.

@sigmavirus24

sigmavirus24 Nov 27, 2016

Member

Shouldn't this be:

not (self.name.startswith('_') or self.name.startswith('__'))

This comment has been minimized.

@sigmavirus24

sigmavirus24 Nov 27, 2016

Member

Nevermind, just noticed the test below

@Nurdok Nurdok merged commit 7e800fe into PyCQA:master Dec 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Nurdok Nurdok deleted the Nurdok:feature/private-modules branch Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment