This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Config file warning #280
Merged
Merged
Config file warning #280
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
50075c4
Merge remote-tracking branch 'refs/remotes/PyCQA/master'
shacharoo 2f33cdf
Merge remote-tracking branch 'refs/remotes/PyCQA/master'
shacharoo d82c316
Merge remote-tracking branch 'refs/remotes/PyCQA/master'
shacharoo 191f735
Merge remote-tracking branch 'upstream/master'
shacharoo c00707e
#276 - Adding a warning message to a sectionless config file
shacharoo b6a3ce3
#276 - Update release notes
shacharoo 486d9a1
#276 - Added another test after CR
shacharoo 17fbe41
#276 - Small improvement to the UT
shacharoo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is called for every directory in a project, so a lack of a
pydocstyle
section should generally be treated by just skipping it and checking the parent directory. If you use the default config, you might screw up the configuration (this might happen if, for example, there's asetup.cfg
file for a different tool).This logic should only be applied if
self._run_config.config
is notNone
, i.e., if a specific config file is specified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought this block was in the top level of the method, but in fact it's inside the
self._run_config.config
check. But add a test for this anyway (a config file in the hierarchy that doesn't have a correct section name).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸