New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#273 - Removing D107 from numpy default violations #288

Merged
merged 2 commits into from Oct 8, 2017

Conversation

Projects
None yet
2 participants
@shacharoo
Copy link
Member

shacharoo commented Oct 5, 2017

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added a error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

shacharoo added some commits Oct 5, 2017

@shacharoo shacharoo requested a review from Nurdok Oct 5, 2017

@Nurdok

Nurdok approved these changes Oct 8, 2017

@Nurdok Nurdok merged commit a0c63e0 into PyCQA:master Oct 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shacharoo shacharoo deleted the shacharoo:remove-D107-from-numpy branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment