Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better __all__ parsing and error handling #320

Merged
merged 7 commits into from Oct 14, 2018
Merged

Better __all__ parsing and error handling #320

merged 7 commits into from Oct 14, 2018

Conversation

@Nurdok
Copy link
Member

Nurdok commented Jun 6, 2018

  • Add unit tests and integration tests where applicable.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
@Nurdok Nurdok requested a review from shacharoo Oct 14, 2018
Copy link
Member

shacharoo left a comment

ALGTM.

src/pydocstyle/parser.py Outdated Show resolved Hide resolved
src/pydocstyle/parser.py Outdated Show resolved Hide resolved
src/tests/parser_test.py Show resolved Hide resolved
Copy link
Member

shacharoo left a comment

image

@Nurdok Nurdok merged commit 8f779cf into master Oct 14, 2018
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Nurdok Nurdok deleted the feature/dunder-all branch Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.