Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parser dead loop when meet comment after __all__ #391


Copy link

Hanaasagi commented Aug 1, 2019

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/
    If you've added or changed a command line option,
    you should probably add or change a test in tests/
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

It will resolve #366

Hanaasagi added 2 commits Aug 1, 2019
@Nurdok Nurdok merged commit 174eca6 into PyCQA:master Aug 2, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
continuous-integration/travis-ci/pr The Travis CI build failed

This comment has been minimized.

Copy link

Nurdok commented Aug 2, 2019

Thanks, @Hanaasagi !
I fixed the merge conflicts manually and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.