Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndentationError while parsing function #392

Merged
merged 4 commits into from Aug 12, 2019
Merged

Conversation

@sfstpala
Copy link
Contributor

sfstpala commented Aug 2, 2019

The checker.get_function_args function will fail with an IndentationError if it gets a function_string that is indented. This fixes that. :)

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Aug 2, 2019

Hi @sfstpala! Thanks for the PR.

Can you please do the following?

  1. Add a test (e.g., with the example from #370 or similar).
  2. Rebase on the new master and resolve the conflicts.
@sfstpala sfstpala closed this Aug 5, 2019
@sfstpala sfstpala force-pushed the sfstpala:master branch from f903928 to eebb17b Aug 5, 2019
sfstpala added 3 commits Aug 2, 2019
@sfstpala sfstpala reopened this Aug 5, 2019
@sfstpala sfstpala changed the title Fix IndentationError while parsing function Fix IndentationError while parsing function, fixes #370 Aug 5, 2019
@sfstpala sfstpala changed the title Fix IndentationError while parsing function, fixes #370 Fix IndentationError while parsing function Aug 5, 2019
@sfstpala

This comment has been minimized.

Copy link
Contributor Author

sfstpala commented Aug 5, 2019

Thanks for taking a look @Nurdok - I added the test and resolved the conflict. Fixes #370

@Hanaasagi

This comment has been minimized.

Copy link
Contributor

Hanaasagi commented Aug 5, 2019

@sfstpala check out #390 . Seems you've duplicated my work ;-)

@Nurdok
Nurdok approved these changes Aug 12, 2019
@Nurdok Nurdok merged commit 0e9d708 into PyCQA:master Aug 12, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Aug 12, 2019

Thanks, @sfstpala !

@Nurdok Nurdok mentioned this pull request Aug 12, 2019
2 of 2 tasks complete
@ljades

This comment has been minimized.

Copy link

ljades commented Aug 12, 2019

Thank you so much for getting on this! When might we expect a version bump on PyPi with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.