Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove D413 from the pep257 convention #404

Merged
merged 2 commits into from Sep 21, 2019
Merged

Remove D413 from the pep257 convention #404

merged 2 commits into from Sep 21, 2019

Conversation

@samj1912
Copy link
Contributor

samj1912 commented Sep 19, 2019

Closes #401

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented Sep 19, 2019

The second tick box is easy to satisfy now you have the pull request number.

One of the examples on #401 could be used for a test case perhaps? I'd use the PEP257 example deliberately as it shows why the (revised) D413 is not suitable for the PEP257 convention.

@samj1912 samj1912 force-pushed the samj1912:patch-1 branch from 87dc939 to faacf5e Sep 21, 2019
@samj1912

This comment has been minimized.

Copy link
Contributor Author

samj1912 commented Sep 21, 2019

@Nurdok tests and release notes updated. Review pls.

@Nurdok
Nurdok approved these changes Sep 21, 2019
@Nurdok Nurdok merged commit fec1b89 into PyCQA:master Sep 21, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samj1912 samj1912 deleted the samj1912:patch-1 branch Sep 21, 2019
@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Sep 21, 2019

Thanks @samj1912!

@MarkusPiotrowski MarkusPiotrowski mentioned this pull request Sep 26, 2019
3 of 3 tasks complete
@godlygeek godlygeek mentioned this pull request Dec 5, 2019
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.