Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCONLY] Fix misnamed D416 reference: `s/semicolon/colon/g` #409

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@jcb91
Copy link
Contributor

jcb91 commented Sep 24, 2019

Hi! I got rather confused reading the docs about references to section names ending in semicolons. What's meant, and what D416 is actually checking for, is sections ending in colons. This PR just fixes those references. I don't think this needs new tests, since it changes only the message, not the code or behaviour, but of course let me know if that's not correct :)

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

Copy link
Contributor

samj1912 left a comment

Lgtm

@samj1912

This comment has been minimized.

Copy link
Contributor

samj1912 commented Sep 24, 2019

Sorry about introducing this error. :p

@Nurdok
Nurdok approved these changes Oct 8, 2019
@Nurdok

This comment has been minimized.

Copy link
Member

Nurdok commented Oct 8, 2019

Thanks, @jcb91! Merging.

@Nurdok Nurdok merged commit e1e84c3 into PyCQA:master Oct 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.