Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decorator parsing #411

Merged
merged 1 commit into from Oct 23, 2019
Merged

Fix decorator parsing #411

merged 1 commit into from Oct 23, 2019

Conversation

@samj1912
Copy link
Contributor

samj1912 commented Oct 1, 2019

Fixes #410

The bug existed because we were not accounting for cases which should
be treated as a logical new line.

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@samj1912

This comment has been minimized.

Copy link
Contributor Author

samj1912 commented Oct 1, 2019

@Nurdok review please :)

src/pydocstyle/parser.py Outdated Show resolved Hide resolved
src/pydocstyle/parser.py Outdated Show resolved Hide resolved
@samj1912 samj1912 force-pushed the samj1912:fix-decorator-parsing branch from e4adfa0 to fc6131b Oct 13, 2019
@samj1912

This comment has been minimized.

Copy link
Contributor Author

samj1912 commented Oct 13, 2019

Addressed comments - ready for review again.

@samj1912 samj1912 requested a review from Nurdok Oct 13, 2019
@samj1912 samj1912 force-pushed the samj1912:fix-decorator-parsing branch from fc6131b to 419becd Oct 13, 2019
Copy link
Member

Nurdok left a comment

LGTM, please rebase so I can merge.

Fixes #410

The bug existed because we were not accounting for cases which should
be treated as a logical new line.
@samj1912 samj1912 force-pushed the samj1912:fix-decorator-parsing branch from 419becd to 395f836 Oct 21, 2019
@samj1912

This comment has been minimized.

Copy link
Contributor Author

samj1912 commented Oct 21, 2019

@Nurdok done

@Nurdok
Nurdok approved these changes Oct 23, 2019
@Nurdok Nurdok merged commit c9feef2 into PyCQA:master Oct 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samj1912 samj1912 deleted the samj1912:fix-decorator-parsing branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.