Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skip on module level messages #427

Merged
merged 5 commits into from Oct 29, 2019
Merged

Allow skip on module level messages #427

merged 5 commits into from Oct 29, 2019

Conversation

@snudler6
Copy link
Contributor

snudler6 commented Oct 26, 2019

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@snudler6

This comment has been minimized.

Copy link
Contributor Author

snudler6 commented Oct 26, 2019

resolves #418

docs/release_notes.rst Outdated Show resolved Hide resolved
@Nurdok
Nurdok approved these changes Oct 26, 2019
@Nurdok Nurdok merged commit 667d9be into PyCQA:master Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bsamseth

This comment has been minimized.

Copy link

bsamseth commented Jan 9, 2020

While this works for the test case, it doesn't work if there is a comment before the module docstring. An example that still reports and error:

# -*- coding: utf-8 -*-
# noqa: D400
"""No period at the end""" 

Encoding pragmas, or #!/path/to/python comments are quite common, so I think this should be fixed to account for this.

I've added a PR with a fix, see #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.