Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove D413 from the google convention #430

Merged
merged 3 commits into from Nov 30, 2019

Conversation

@justinludwig
Copy link
Contributor

justinludwig commented Nov 26, 2019

As none of the examples in the Google Python Style Guide show a docstring with an extra blank line at the end (see the 3.8.1 Docstrings section in particular), error D413 should be excluded from the default "google" convention.

See #429 for a test case with examples from the Google Python Style Guide; see also #401 for D413 in relation to the "pep257" convention.


Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

justinludwig and others added 3 commits Nov 24, 2019
As none of the examples in the
[Google Python Style Guide](https://google.github.io/styleguide/pyguide.html)
show a docstring with an extra blank line at the end (see the
[3.8.1 Docstrings](https://google.github.io/styleguide/pyguide.html#381-docstrings)
section in particular), error D413 should be excluded from the default
"google" convention.

See #429 for a test case with examples from the Google Python Style
Guide; see also #401 for D413 in relation to the "pep257" convention.
@Nurdok
Nurdok approved these changes Nov 30, 2019
@Nurdok Nurdok merged commit dbbf578 into PyCQA:master Nov 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.