Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Allow for greater flexibility in parsing __all__. #67

Merged
merged 1 commit into from
Apr 1, 2014
Merged

Allow for greater flexibility in parsing __all__. #67

merged 1 commit into from
Apr 1, 2014

Conversation

jkrukoff
Copy link
Contributor

This patch allows for newlines and comments to be inserted between the opening
parenthesis or bracket for the all list and the first string value.
Additionally, a test has been added for this case.

Proposed to fix #66.

This patch allows for newlines and comments to be inserted between the opening
parenthesis or bracket for the __all__ list and the first string value.
Additionally, a test has been added for this case.

Proposed fix for Issue #66.
keleshev added a commit that referenced this pull request Apr 1, 2014
Allow for greater flexibility in parsing __all__.
@keleshev keleshev merged commit 1322f21 into PyCQA:master Apr 1, 2014
@keleshev
Copy link
Contributor

keleshev commented Apr 1, 2014

@jkrukoff looks great, thanks.

@Nurdok
Copy link
Member

Nurdok commented Jun 27, 2014

The merge of this pull request causes the test suite to fail. Shouldn't it be reverted?

@Nurdok
Copy link
Member

Nurdok commented Jun 27, 2014

My mistake - it seems the master branch is failing for some time.
I tried running git bisect, but it seems that running py.test fails back up to where curses was removed from the code, and I can run it beforehand because I'm on Windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing __all__ when opening parenthesis is on line by itself.
3 participants