Allow for greater flexibility in parsing __all__. #67

Merged
merged 1 commit into from Apr 1, 2014

Projects

None yet

3 participants

@jkrukoff
Contributor

This patch allows for newlines and comments to be inserted between the opening
parenthesis or bracket for the all list and the first string value.
Additionally, a test has been added for this case.

Proposed to fix #66.

@jkrukoff jkrukoff Allow for greater flexibility in parsing __all__.
This patch allows for newlines and comments to be inserted between the opening
parenthesis or bracket for the __all__ list and the first string value.
Additionally, a test has been added for this case.

Proposed fix for Issue #66.
35b1129
@keleshev keleshev merged commit 1322f21 into PyCQA:master Apr 1, 2014

1 check failed

default The Travis CI build failed
Details
@keleshev
Contributor
keleshev commented Apr 1, 2014

@jkrukoff looks great, thanks.

@Nurdok
Member
Nurdok commented Jun 27, 2014

The merge of this pull request causes the test suite to fail. Shouldn't it be reverted?

@Nurdok
Member
Nurdok commented Jun 27, 2014

My mistake - it seems the master branch is failing for some time.
I tried running git bisect, but it seems that running py.test fails back up to where curses was removed from the code, and I can run it beforehand because I'm on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment