Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for greater flexibility in parsing __all__. #67

Merged
merged 1 commit into from Apr 1, 2014

Conversation

Projects
None yet
3 participants
@jkrukoff
Copy link
Contributor

commented Mar 31, 2014

This patch allows for newlines and comments to be inserted between the opening
parenthesis or bracket for the all list and the first string value.
Additionally, a test has been added for this case.

Proposed to fix #66.

Allow for greater flexibility in parsing __all__.
This patch allows for newlines and comments to be inserted between the opening
parenthesis or bracket for the __all__ list and the first string value.
Additionally, a test has been added for this case.

Proposed fix for Issue #66.

keleshev added a commit that referenced this pull request Apr 1, 2014

Merge pull request #67 from jkrukoff/master
Allow for greater flexibility in parsing __all__.

@keleshev keleshev merged commit 1322f21 into PyCQA:master Apr 1, 2014

1 check failed

default The Travis CI build failed
Details
@keleshev

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2014

@jkrukoff looks great, thanks.

@Nurdok

This comment has been minimized.

Copy link
Member

commented Jun 27, 2014

The merge of this pull request causes the test suite to fail. Shouldn't it be reverted?

@Nurdok

This comment has been minimized.

Copy link
Member

commented Jun 27, 2014

My mistake - it seems the master branch is failing for some time.
I tried running git bisect, but it seems that running py.test fails back up to where curses was removed from the code, and I can run it beforehand because I'm on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.