This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Make setters private#69
Closed
adiroiban wants to merge 2 commits intoPyCQA:masterfrom
chevah:private_setter
Closed
Make setters private#69adiroiban wants to merge 2 commits intoPyCQA:masterfrom chevah:private_setter
adiroiban wants to merge 2 commits intoPyCQA:masterfrom
chevah:private_setter
Conversation
Member
|
Your tests are failing https://travis-ci.org/GreenSteam/pep257/builds/22946274 |
Author
|
Master is also failing and is not my fault :( : https://travis-ci.org/GreenSteam/pep257/builds/22006902 Please see command used for running my tests. |
Author
|
I now see that pep8 is failing. I will udpate my code ... is ugly to work with a master branch which is not clean. |
Member
|
@adiroiban the master branch is now clean. Can you pull and merge it with your code so I can see if your tests are failing or not? |
Author
|
Hi. I don't have time right now to continue working on this but feel free to fork the branch. |
glennmatthews
added a commit
to glennmatthews/pep257
that referenced
this pull request
Feb 18, 2015
Nurdok
added a commit
that referenced
this pull request
Mar 25, 2015
Make setters private (rework of #69)
Contributor
|
This can probably be closed now that #107 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pep257 complains that setters (and mabye deleters) have no docstring.
Here is an example
Documentation tools should ignore setters and deletes docstring when creating api docs.
Also, setters and deleters are pretty standard and they will only have a boilerplate text which will not say anything new.
Changes
Updated the parser to keep a record for decorators.
In Method.is_private i check the list of decorators and if decorators start with same name then it is marked private.
I have removed unused / broken tests from test_pep257 as this is just hoarding of junk. http://blog.8thlight.com/uncle-bob/2014/04/03/Code-Hoarders.html
Added test for new code.
How to test
Check that changed make sense
py.test test_pep257.py -vLet me know if you find this useful.
Thanks!