Remove py2 references from README #732
Conversation
README.rst
Outdated
|
|
||
| * You can also invoke Pyflakes with ``python3 -m pyflakes .`` or | ||
| ``python2 -m pyflakes .`` if you have it installed for both versions. | ||
| * You can invoke Pyflakes with ``python -m pyflakes .`` |
There was a problem hiding this comment.
I think this can be removed entirely -- or adjusted to use something like python3.10 -m pip install ... and python3.10 -m pyflakes ...
There was a problem hiding this comment.
Of the two, I'm maybe team delete since i'd rather not add another thing for maintainers to update in the future
That said, in the setup.py it seems like pyflakes always adds some entrypoint, so what if we said:
You can invoke Pyflakes with
pyflakes .
There was a problem hiding this comment.
could use python3.# ... so it doesn't need updating again. the original intent of this was to show how to run it per interpreter -- there isn't really much point in showing pyflakes . though
There was a problem hiding this comment.
python3.# ... works for me!
There was a problem hiding this comment.
Changed my mind, removing seems simpler. Also, the flake8 part of the section is implied in Design Principles so took out the "Useful tips" section
There was a problem hiding this comment.
this section is important, I want you to adjust it to still make sense but without python 2 -- no reason to throw out the baby with the bathwater
There was a problem hiding this comment.
okay gave it another shot, appreciate your patience!
README.rst
Outdated
| * Be sure to install it for a version of Python which is compatible | ||
| with your codebase: for Python 2, ``pip2 install pyflakes`` and for | ||
| Python3, ``pip3 install pyflakes``. | ||
|
|
||
| * You can also invoke Pyflakes with ``python3 -m pyflakes .`` or | ||
| ``python2 -m pyflakes .`` if you have it installed for both versions. | ||
| * You can invoke Pyflakes with ``python3.# -m pyflakes .`` |
There was a problem hiding this comment.
ah I meant to keep the original messaging
dannysepler
force-pushed
the
no-py2-in-readme
branch
from
f30aad0
to
336d376
Compare
dannysepler
force-pushed
the
no-py2-in-readme
branch
from
336d376
to
b83cab5
Compare
README.rst
Outdated
| * Be sure to install it for a version of Python which is compatible | ||
| with your codebase: for Python 2, ``pip2 install pyflakes`` and for | ||
| Python3, ``pip3 install pyflakes``. |
There was a problem hiding this comment.
this first part is still important but should be replaced with python#.# -m pip ...
Since #707, I don't think pyflakes is runnable from a py2 context anymore