Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new extension for detecting integer comparisons against zero #1243

Merged
merged 1 commit into from Dec 31, 2016

Conversation

@atodorov
Copy link
Contributor

commented Dec 28, 2016

Similar to #1183 but for comparisons to zero. Again made it as an extension because this may not be what you need. I've used this to refactor a great deal of projects I've been working on though where such comparisons are not needed and expand the size of mutation test matrix in the order of 1000s of additional cases.

Please review and comment, thanks.

@atodorov atodorov force-pushed the MrSenko:ext_compare_to_zero branch from 4509479 to 9180673 Dec 30, 2016

@PCManticore

This comment has been minimized.

Copy link
Member

commented Dec 30, 2016

Thank you, looks nice and clean.

By the way, we are using pytest since some recent changes. Can you modify your code so that it won't complain about WC1 /home/travis/build/PyCQA/pylint/.tox/py35/lib/python3.5/site-packages/pylint/test/extensions/test_comparetozero.py cannot collect test class 'TestReporter' because it has a __init__ constructor? Thank you.

@atodorov atodorov force-pushed the MrSenko:ext_compare_to_zero branch from 9180673 to 6a8a69d Dec 30, 2016

@atodorov

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2016

PR updated for the pytest error listed above but Travis fails, I believe due to unrelated issues.

@degustaf

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2016

@atodorov Yeah, a change made to astroid is making that test fail. The PR to fix it has already been made.

@PCManticore

This comment has been minimized.

Copy link
Member

commented Dec 31, 2016

Thank you @atodorov

@PCManticore PCManticore merged commit 5341437 into PyCQA:master Dec 31, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.