New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --ignore-imports for multi-line imports #2424

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@chkno
Contributor

chkno commented Aug 19, 2018

This fixes #1422 and fixes #2019.

(I tried running the tox tests, but some of them seemed to be failing at HEAD, and I didn't have all the interpreters that it wanted to check installed on my machine.)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 19, 2018

Coverage Status

Coverage increased (+0.007%) to 90.253% when pulling 19a14b8 on chkno:master into 664c712 on PyCQA:master.

coveralls commented Aug 19, 2018

Coverage Status

Coverage increased (+0.007%) to 90.253% when pulling 19a14b8 on chkno:master into 664c712 on PyCQA:master.

@PCManticore

@chkno Thank you so much for tackling this issue! This PR looks good, left just a couple of small improvements to be made. Also we'd need some boilerplate before merging:

  • please add yourself to CONTRIBUTORS file, if you are not already there
  • let's add a Changelog entry describing what this change fixes
Show outdated Hide outdated pylint/checkers/similar.py Outdated
Show outdated Hide outdated pylint/checkers/similar.py Outdated
Show outdated Hide outdated pylint/test/unittest_checker_similar.py Outdated
@chkno

This comment has been minimized.

Show comment
Hide comment
@chkno

chkno Aug 21, 2018

Contributor

I updated Changelog and CONTRIBUTORS. (I saw these instructions in doc/development_guide/contribute.rst, but I wasn't sure if they were intended for a change this small. Thank you for walking me through this.)

(I rebased to resolve a Changelog merge conflict. Sorry if this was the wrong thing to do.)

Contributor

chkno commented Aug 21, 2018

I updated Changelog and CONTRIBUTORS. (I saw these instructions in doc/development_guide/contribute.rst, but I wasn't sure if they were intended for a change this small. Thank you for walking me through this.)

(I rebased to resolve a Changelog merge conflict. Sorry if this was the wrong thing to do.)

@PCManticore

This comment has been minimized.

Show comment
Hide comment
@PCManticore

PCManticore Sep 29, 2018

Member

Thanks a lot for the PR @chkno ! I've merged this manually to solve the conflicts and just pushed the relevant commit to master.

Member

PCManticore commented Sep 29, 2018

Thanks a lot for the PR @chkno ! I've merged this manually to solve the conflicts and just pushed the relevant commit to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment