This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cdce8p I added the NamedTuple. However, doing this separately was (quite) awful because of the various new mypy errors that I already fixed in this PR. (For example raising the Exception on if not _worker_linter).
So I added it here!
Not sure if I agree here. This would probably lead us to having to add Path to many other typings down the line. The current flow of pylint clearly does not allow Path to be passed. With a little refactor we can even get the last instance of Path to also become a str. Having to add Union[Path, str] instead of str everywhere might clutter the codebase.
Yes, also the migration to Path is also a huge endeavor with not a lot of clear benefit right now. Most os.path handles Union[Path, str] so technically that's what we can probably handle on most of the function, but finding out where we can't is probably not worth the time and crashes it will create.
This now includes the relevant changes to the tests to make this work. As discussed in PR description I believe the tests check things that cannot happen in real world scenarios. The description includes some additional reasoning for this and a description of the changes to the tests.
MaintenanceDiscussion or action around maintaining pylint or the dev workflow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.