-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writer timestamps handling improvements #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the approach so far. Final changes dependent upon opened discussion.
Co-authored-by: Rodrigo Tenorio <rodrigo.tenorio@ligo.org>
Could, but I'd leave that as a future enhancement request? Maybe together with having a central timestamps parsing util that |
-> #493 |
Left to do: sanity check that the first column is actually |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 73.21% 73.39% +0.18%
==========================================
Files 21 21
Lines 4304 4311 +7
==========================================
+ Hits 3151 3164 +13
+ Misses 1153 1147 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added check for integer timestamps and test case for different warnings.
a9df6f7
to
959fb77
Compare
detectors
iftimestamps
are a string