Understand and implement POST /repos/:user/:repo/pulls/:number/comments with in_reply_to #37

Closed
jacquev6 opened this Issue May 29, 2012 · 1 comment

Projects

None yet

1 participant

@jacquev6
Member
@jacquev6 jacquev6 was assigned May 29, 2012
@jacquev6 jacquev6 added a commit that referenced this issue May 29, 2012
@jacquev6 jacquev6 Remove some easy or obsolete 'todo's
See issues #2 #4 #18 #35 #36 #37
e5d5732
@jacquev6
Member

In previous commit, I get an error response from Github for the following request:

POST https://api.github.com/repos/jacquev6/PyGithub/pulls/31/comments
{"body": "Reply created by PyGithub", "in_reply_to": 1580134}

The error is:
422 Unprocessable Entity
{"errors":[
{"resource":"PullRequestReviewComment","code":"missing_field","field":"commit_id"},
{"resource":"PullRequestReviewComment","code":"missing_field","field":"path"},
{"resource":"PullRequestReviewComment","code":"missing_field","field":"diff_hunk"},
{"resource":"PullRequestReviewComment","code":"missing_field","field":"original_position"}
],"message":"Validation Failed"}

I am lazy and won't contact Github about that. If someone really cares about this API being in PyGithub, please show me a POST with in_reply_to that works, and I will use it.

@jacquev6 jacquev6 closed this Dec 24, 2013
@jacquev6 jacquev6 added the v1 label Mar 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment