-
Notifications
You must be signed in to change notification settings - Fork 122
added atc support for proflex backend #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we should subclass the Proflex in a new ATCBackend that adds these methods? My understanding is the automated close/open lid are not supported on the Proflex itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right. it's probably for the best to have a separate backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it's better to have something like thermofisher_thermocycler and have proflex, ATC and in the future quantstudio inherit from that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds great!
Proflex subclass of ThermoFisherThermocycler shouldn't add anything right?
also im thinking ThermoFisherThermocycler should be an abc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think that's a good idea
|
what do you think @xbtu2 |
|
looks good to me! |
|
thanks for contributing this! |
No description provided.