Skip to content

Conversation

@xbtu2
Copy link
Contributor

@xbtu2 xbtu2 commented Oct 10, 2025

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we should subclass the Proflex in a new ATCBackend that adds these methods? My understanding is the automated close/open lid are not supported on the Proflex itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. it's probably for the best to have a separate backend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it's better to have something like thermofisher_thermocycler and have proflex, ATC and in the future quantstudio inherit from that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great!

Proflex subclass of ThermoFisherThermocycler shouldn't add anything right?

also im thinking ThermoFisherThermocycler should be an abc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think that's a good idea

@rickwierenga
Copy link
Member

what do you think @xbtu2

@xbtu2
Copy link
Contributor Author

xbtu2 commented Oct 11, 2025

looks good to me!

@rickwierenga rickwierenga merged commit 3dad907 into PyLabRobot:main Oct 11, 2025
9 checks passed
@rickwierenga
Copy link
Member

thanks for contributing this!

@xbtu2 xbtu2 deleted the atc_backend branch October 11, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants