Fix STARBackend.get core() & STARBackend.put core()
#710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
The Problem
STARBackend.get core()&STARBackend.put core()was 1 mm too high on a STAR when compared to VENUS - I noticed because the CORE-gripper tool pickup was working inconsistently.STARBackend.core_adjustment: Coordinateattribute. However, theCoordinateclass takes mm as offset values andSTARBackend.get core()&STARBackend.put core()have so far been given the mm coordinate values straight into the firmware commands dmm values. This also fails when a float is used in theCoordinateclass .PR Content
STARBackend.get core()&STARBackend.put core()x-coordinate for usage on a STAR - validated on machine.Coordinatemm to dmm.