Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend framework #238

Merged
merged 11 commits into from May 22, 2019

Conversation

Projects
2 participants
@befeleme
Copy link
Contributor

commented May 12, 2019

#187
Pridano nacteni adresaru test_.
Pridano zpracovani hodnoty registers, tedy kolik kol se ma odehrat.
Posunuto test_ soubory z hlavni slozky projektu do tests/

Pravdeopodobne budou se muset upravit error handlingy (ted jsou dost nahodne tam, kde mi to failovalo)

Pokud byste si chtely zkusit napsat dalsi test, je treba:

  • vytvorit unikatni adresar tests/test_<neco>
    • do nej ulozit map.json vytvoreny v Tiled
      • mapa musi obsahovat start a stop policka. Oboji musi byt spravne natoceno (tak, jak chceme, aby robot skoncil)
    • napsat commands.yaml, ve kterem bude minimalne pocet registru (pokud chcete otestovat "holy" efekt policka bez karetnich pohybu)

Zatim hra overi, ze zmenily se smer a koordinaty - porovna se smerem a koordinatami stop policek.
Rozsahlejsi overeni dopisu casem.

@befeleme befeleme added this to Rozdělané in Projekt May 13, 2019

@JureckovaK
Copy link
Contributor

left a comment

Proč je ve složce tests prázdný soubor __init__.py?

Show resolved Hide resolved tests/test_effects.py Outdated
Show resolved Hide resolved tests/test_effects.py Outdated
Show resolved Hide resolved tests/test_effects.py Outdated
Show resolved Hide resolved tests/test_effects.py Outdated
Show resolved Hide resolved tests/test_effects.py Outdated
Show resolved Hide resolved tests/test_effects.py Outdated
@befeleme

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

__init__.py se musel pridat po prehozeni souboru s testy do podslozky tests/. Detaily jsme si vysvetili na srazu :).

@JureckovaK
Copy link
Contributor

left a comment

Super práce! Logicky napsané/přejmenované, mnohem lépe se v tom orientuje a dává mi to smysl :)

@JureckovaK JureckovaK merged commit 568e9d7 into PyLadiesCZ:master May 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Projekt automation moved this from Rozdělané to Hotovo May 22, 2019

@befeleme befeleme deleted the befeleme:new-tests branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.